fix(helm): Use parentesized guards for control plane tracing #14636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to #14634, This adds parenthesized guards for the control plane tracing values check Signed-off-by: Scott Fleener <[email protected]>
olix0r
approved these changes
Oct 21, 2025
olix0r
reviewed
Oct 21, 2025
| {{ define "partials.linkerd.trace" -}} | ||
| {{ if .Values.controller.tracing.enabled -}} | ||
| {{ if ((.Values.controller.tracing).enabled) -}} | ||
| {{- if empty .Values.controller.tracing.collector.endpoint }} |
Member
There was a problem hiding this comment.
do we need defaults if collector is missing?
olix0r
reviewed
Oct 21, 2025
| {{ define "partials.linkerd.trace" -}} | ||
| {{ if .Values.controller.tracing.enabled -}} | ||
| {{ if ((.Values.controller.tracing).enabled) -}} | ||
| {{- if empty .Values.controller.tracing.collector.endpoint }} |
Member
There was a problem hiding this comment.
Suggested change
| {{- if empty .Values.controller.tracing.collector.endpoint }} | |
| {{- if empty (.Values.controller.tracing.collector).endpoint }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #14634, This adds parenthesized guards for the control plane tracing values check in the case where we upgrade with existing values.